Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Handle invalid subdomain error in Mac script #117
Merged
Conversation
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi, In this PR, I have-
Put a condition to check if the subdomain is complete account URL and is containing .loggly.com as well. If yes, then mark this subdomain as invalid and exit the script with proper error message.
Checked for both response code type from CURL - 200 OK & 200. Most of the curl versions return 200 OK but some of them also return 200 so script should mark the subdomain valid in both response type.
Currently, I am in process of testing the script in various scenarios like by passing valid/invalid subdomain and check the script's execution.