Handle invalid subdomain error in Mac script#117
Merged
duttly merged 1 commit intologgly:masterfrom May 24, 2018
Merged
Conversation
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, In this PR, I have-
Put a condition to check if the subdomain is complete account URL and is containing .loggly.com as well. If yes, then mark this subdomain as invalid and exit the script with proper error message.
Checked for both response code type from CURL - 200 OK & 200. Most of the curl versions return 200 OK but some of them also return 200 so script should mark the subdomain valid in both response type.
Currently, I am in process of testing the script in various scenarios like by passing valid/invalid subdomain and check the script's execution.