Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for verification #31

Merged
merged 3 commits into from Sep 2, 2013
Merged

Updates for verification #31

merged 3 commits into from Sep 2, 2013

Conversation

@ivangonekrazy
Copy link
Contributor

@ivangonekrazy ivangonekrazy commented Aug 31, 2013

  • extend the verification loop timeout
  • adds an 'example' tag to the syslog-ng/rsyslogd templates to workaround https://loggly.jira.com/browse/LOGGLY-3884
  • adds some more feedback while we're polling for the verification event
♥ Ivan Tam ♥ added 2 commits Aug 31, 2013
Also adds more feedback during the verify loop.
@ivangonekrazy
Copy link
Contributor Author

@ivangonekrazy ivangonekrazy commented Aug 31, 2013

@rhigdon @jimniz please review and merge if we wanna pull in the workaround for the APIv2 no-tag issue.

@philip-loggly
Copy link
Contributor

@philip-loggly philip-loggly commented Sep 2, 2013

Seems like we have no choice but to add this "example" tag to the template. Is that correct?

@ivangonekrazy
Copy link
Contributor Author

@ivangonekrazy ivangonekrazy commented Sep 2, 2013

In the short term, yes.

Otherwise the API call to do the verification fails. There's alreadyva fix
for the api endpoint. We just need to deploy it after GA
On Sep 1, 2013 6:27 PM, "philip-loggly" notifications@github.com wrote:

Seems like we have no choice but to add this "example" tag to the
template. Is that correct?


Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-23637256
.

@philip-loggly
Copy link
Contributor

@philip-loggly philip-loggly commented Sep 2, 2013

Why make the timeout so long? It seems excessive.

philip-loggly added a commit that referenced this pull request Sep 2, 2013
Updates for verification
@philip-loggly philip-loggly merged commit d0f35ef into master Sep 2, 2013
@philip-loggly
Copy link
Contributor

@philip-loggly philip-loggly commented Sep 2, 2013

Merged, though I would like to know why the timeout is so long.

@ivangonekrazy
Copy link
Contributor Author

@ivangonekrazy ivangonekrazy commented Sep 2, 2013

The previous timeout length was too short and verifications ended up always timing out.

I wanted to err on the side of letting the script try for longer rather than generating more emails for support, at least for the short-term until we figure out the fate of the current script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.