Improve JSON response. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all the extra spaces from the json. Also simplify the generation of the json. Codespace is cheap so duplicated strings is not an issue. But generating strings from different parts is more expensive in clock cycles. Add a helper funcion `bool_to_html()` to generate bool value for html output.
Owner
|
Great idea! Tested and works perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the extra spaces from the json.
Also simplify the generation of the json.
Codespace is cheap so duplicated strings is not an issue. But generating strings from different parts is more expensive in clock cycles.
Add a helper funcion
bool_to_html()to generate bool value for html output.JSON output now looks like:
eee.json:[{"portNum":5,"isSFP":1},{"portNum":1,"isSFP":0,"eee":"111","eee_lp":"000","active":0},{"portNum":2,"isSFP":0,"eee":"111","eee_lp":"000","active":0},{"portNum":3,"isSFP":0,"eee":"111","eee_lp":"000","active":0},{"portNum":4,"isSFP":0,"eee":"111","eee_lp":"111","active":1},{"portNum":6,"isSFP":1}]status.json:[{"portNum":5,"isSFP":1,"enabled":0,"link":1,"txG":"0x00","txB":"0x0","rxG":"0x00","rxB":"0x0"},"portNum":1,"isSFP":0,"enabled":1,"link":0,"txG":"0x00","txB":"0x0","rxG":"0x00","rxB":"0x0"},"portNum":2,"isSFP":0,"enabled":1,"link":2,"txG":"0x03c8","txB":"0x0","rxG":"0x053f","rxB":"0x1"},"portNum":3,"isSFP":0,"enabled":1,"link":0,"txG":"0x00","txB":"0x0","rxG":"0x00","rxB":"0x0"},"portNum":4,"isSFP":0,"enabled":1,"link":5,"txG":"0x00","txB":"0x0","rxG":"0x00","rxB":"0x0"},"portNum":6,"isSFP":1,"enabled":0,"link":1,"txG":"0x00","txB":"0x0","rxG":"0x00","rxB":"0x0"}]