Skip to content

docs(agents): require code review before EVERY commit#76

Merged
hyoshi merged 1 commit intomainfrom
docs/agents-commit-workflow
May 1, 2026
Merged

docs(agents): require code review before EVERY commit#76
hyoshi merged 1 commit intomainfrom
docs/agents-commit-workflow

Conversation

@hyoshi
Copy link
Copy Markdown
Collaborator

@hyoshi hyoshi commented May 1, 2026

Codifies the workflow rule reinforced after PR #20 (OAuth helper, 2 HIGH issues found post-hoc) and PR #75 fixup commit pushed without re-review.

Adds a new ## Commit Workflow section to AGENTS.md between Coding Standards and Test Coverage:

  • Every code commit requires a code-reviewer pass (fixup, lint, review-response commits all qualify)
  • Security boundary changes require security-reviewer in parallel
  • HIGH/CRITICAL findings → fix → re-run review → commit
  • Exceptions (visual review only): docs/CHANGELOG/version bumps/Dependabot/typo fixes
  • 'Tests green' and 'lint clean' are NOT substitutes for code review

CLAUDE.md delegates to AGENTS.md, so this binds future Claude Code sessions automatically.

…e EVERY commit

Codifies the rule reinforced after PR #20 (OAuth helper, 2 HIGH issues found post-hoc) and PR #75 fixup (review-response commit pushed without re-review). Fixup, lint, and review-response commits all require their own review pass — a previous review on the same branch does NOT exempt follow-up commits.

Exceptions (visual review only): docs/README/CHANGELOG, version bumps, Dependabot Actions bumps, typo fixes in comments.
@hyoshi hyoshi merged commit 9a63f24 into main May 1, 2026
8 checks passed
@hyoshi hyoshi deleted the docs/agents-commit-workflow branch May 1, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant