Remove Redundant active Flag From AMM PoolDefinition

[3esmit]

Fixes #25

Summary

This PR removes the redundant active flag from amm_core::PoolDefinition and replaces its callers with explicit liquidity_pool_supply checks.

After the minimum-liquidity lock, active no longer tracked anything meaningfully distinct from pool initialization, so the AMM now makes those readiness checks directly from LP supply at each call site.

Changes

• remove active from the serialized PoolDefinition schema
• update new_definition to reject any existing pool definition with nonzero LP supply
• update swap_exact_input, swap_exact_output, sync_reserves, and remove_liquidity to gate on explicit minimum-liquidity checks instead of active
• update AMM unit and integration fixtures to use zero-supply or below-minimum-liquidity states explicitly
• refresh comments and panic messages so they describe LP-supply semantics instead of active/inactive status

Testing

• cargo +1.94.0 test -p amm_program
• RISC0_DEV_MODE=1 cargo +1.94.0 test -p integration_tests --test amm
• cargo +nightly fmt --all -- --check
• taplo fmt --check .
• RISC0_SKIP_BUILD=1 cargo +1.94.0 clippy --workspace --all-targets -- -D warnings
• RISC0_DEV_MODE=1 cargo +1.94.0 test --workspace --exclude integration_tests
• RISC0_DEV_MODE=1 cargo +1.94.0 test -p integration_tests

Notes

• This PR intentionally changes the serialized PoolDefinition layout by removing active, so older serialized pool bytes are not schema-compatible with this version.
• This PR does not fold in issue Remove dead re-initialization code path from new_definition #26. The current zero-supply reinitialization branch in new_definition remains as a follow-up cleanup risk.

[Copilot]

Pull request overview

This PR removes the redundant active field from amm_core::PoolDefinition (and its serialized layout) and updates the AMM to gate “pool readiness” using explicit liquidity_pool_supply checks (primarily against MINIMUM_LIQUIDITY), with corresponding fixture/test updates.

Changes:

• Removes active from PoolDefinition and updates docs/comments to describe LP-supply-based readiness semantics.
• Updates new_definition to reject initialization when the existing pool has nonzero LP supply.
• Replaces active checks with explicit liquidity_pool_supply minimum-liquidity checks in swap/sync/remove flows; updates unit and integration tests/fixtures accordingly.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
amm/core/src/lib.rs	Removes active from the serialized PoolDefinition schema and updates related docs.
amm/src/new_definition.rs	Replaces active gating with liquidity_pool_supply == 0 precondition for initialization/reinit.
amm/src/swap.rs	Updates swap validation to require liquidity_pool_supply >= MINIMUM_LIQUIDITY.
amm/src/sync.rs	Updates sync gating to require liquidity_pool_supply >= MINIMUM_LIQUIDITY.
amm/src/remove.rs	Updates remove-liquidity gating to require liquidity_pool_supply >= MINIMUM_LIQUIDITY and removes active field updates.
amm/src/tests.rs	Refactors unit test fixtures and expected panic messages to use LP-supply semantics.
integration_tests/tests/amm.rs	Refactors integration fixtures and test names to remove active and model zero-supply/below-min states explicitly.
amm/methods/guest/src/bin/amm.rs	Updates instruction docs to reference “existing zero-supply” reinitialization semantics.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[3esmit]

@copilot comments are valid, however in the context of #26 they are not an issue, as this code will be further refactored to remove reinit paths, we don't need to address those changes, as they would be removed in #26

[0x-r4bbit]

Change LGTM!

Only thing I'd ask is to mark this change as a breaking change in the commit message (we're removing a field in the pool definition)

[3esmit]

mark this change as a breaking change in the commit message (we're removing a field in the pool definition)

Added a ! as first character of the commit message.

[0x-r4bbit]

Please check how this is done here: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-scope-and--to-draw-attention-to-breaking-change

[0x-r4bbit]

@3esmit updated the commit message for you and rebased. Will merge once green.