Fix tutorial v2#51
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the “wrapping a C library” tutorial and the logos-calc-module example to build the external C library from source during the Nix build (via externalLibInputs + build_command/output_pattern) instead of requiring a pre-built .so/.dylib checked into lib/.
Changes:
- Document and implement building
libcalcfrom source using alib/Makefile+metadata.jsonbuild_command/output_pattern. - Update the example module flake to pass
calc-srcviaexternalLibInputs. - Add module-level
.gitignoreentries for Nix/CMake outputs and the locallib/build/directory.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tutorial-wrapping-c-library.md | Updates Step 1.5 and Nix integration docs to build/stage the C library from source. |
| logos-calc-module/metadata.json | Switches external library config from vendor_path to build_command + output_pattern. |
| logos-calc-module/lib/Makefile | Adds a Makefile used by Nix to compile libcalc as a shared library. |
| logos-calc-module/flake.nix | Adds calc-src and wires it into externalLibInputs. |
| logos-calc-module/.gitignore | Ignores build outputs (result*, build/, lib/build/). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.