Update InboxV2 to use IdentityProvider#103
Open
jazzz wants to merge 8 commits into
Open
Conversation
kaichaosun
reviewed
May 25, 2026
| IP: IdentityProvider, | ||
| { | ||
| account_id: AccountId, | ||
| account: Rc<RefCell<MlsIdentityProvider<IP>>>, |
Contributor
There was a problem hiding this comment.
It should be identity, right?
Also I'm wondering if we can derive account_id from IdentityProvider?
Collaborator
Author
There was a problem hiding this comment.
Hmm great point. We need to lock down our language for the Accounts/Identity Model. Will handle offline
| impl MlsEphemeralPqProvider { | ||
| pub fn new() -> Result<Self, CryptoError> { | ||
| let crypto = LibcruxCryptoProvider::new()?; | ||
| let storage = MemoryStorage::default(); |
Contributor
There was a problem hiding this comment.
Should we inject the storage, so it can be easier to be replaced later with actual store engine.
Collaborator
Author
There was a problem hiding this comment.
This is only ever initialized in a single location - Its east to change the types.
Skipping injection for now, as we can solve the problem later.
osmaczko
approved these changes
May 25, 2026
kaichaosun
approved these changes
May 26, 2026
Contributor
kaichaosun
left a comment
There was a problem hiding this comment.
Good to merge once clearness is finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the sibling PR to #102. It updates InboxV2 to use and abstract IdentityProvider, rather than requiring the internal LogosAccount implementation.
Changes
Deferred Work:
Notes
Future PRs