Merged
Conversation
kaichaosun
approved these changes
Apr 16, 2026
|
|
||
| outputs = { self, nixpkgs, rust-overlay }: | ||
| let | ||
| systems = [ "aarch64-darwin" "x86_64-darwin" "aarch64-linux" "x86_64-linux" ]; |
Contributor
There was a problem hiding this comment.
I'm wondering why windows is not supported here?
Contributor
Author
There was a problem hiding this comment.
good point, I just didn't see it supported widely in other repos/modules
not used and it was causing the error with panic abort
plopezlpz
commented
Apr 17, 2026
| edition = "2024" | ||
|
|
||
| [lib] | ||
| crate-type = ["rlib","staticlib","dylib"] |
Contributor
Author
There was a problem hiding this comment.
the dylib was making the nix build fail with:
error: the linked panic runtime `panic_unwind` is not compiled with this crate's panic strategy `abort`
for now we only use client_ffi.a upstream so removing this
osmaczko
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flake to be able to build from upstream in
logos-chat-module