Merged
Conversation
andelf
force-pushed
the
fix/disable-logseq-graph-name-check
branch
from
ffdfa1c to
5cdeabf
Compare
logseq-cldwalker
approved these changes
Sep 20, 2023
Collaborator
logseq-cldwalker
left a comment
logseq-cldwalker
left a comment
There was a problem hiding this comment.
@andelf Looks reasonable! 👍 🚢
| :status :warning | ||
| :clear? false}])) | ||
| [_dir files] | ||
| ;; disable this check for now |
Collaborator
There was a problem hiding this comment.
Non-blocking: Looks like this comment and docstring about logseq can be removed
See-also: #10246
andelf
force-pushed
the
fix/disable-logseq-graph-name-check
branch
from
5cdeabf to
8d3b608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See-also: #10246
Disable this for now. It's actually safe to use.