fix: Improve iOS native navigation and graphs#12679
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves mobile native navigation, especially iOS tab/search/dialog flows, and replaces the iOS graphs tab with a native SwiftUI-backed graph list/actions bridge.
Changes:
- Adds native iOS graph list rendering, graph actions, pull-to-refresh, and JS/native graph bridge updates.
- Adjusts mobile navigation stack synchronization, search tab transitions, top bar behavior, and bottom sheet dismissal timing.
- Updates mobile dev HTTPS setup, docs, ignore rules, and adds navigation regression tests.
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/mobile/navigation_test.cljs |
Adds regression tests for mobile stack switching, pop-to-root, and search state transitions. |
src/main/mobile/state.cljs |
Changes search tab leave behavior to preserve query state while resetting stack history. |
src/main/mobile/navigation.cljs |
Updates stack sync, browser route synchronization, duplicate push handling, and reset navigation typing. |
src/main/mobile/components/popup.cljs |
Adds native bottom sheet content-ready notification after dismissal. |
src/main/mobile/components/header.cljs |
Adds iOS graph-specific top bar behavior and native graph creation popup handling. |
src/main/mobile/components/app.cljs |
Adds native graph section/action payload generation and iOS bridge effects. |
src/main/mobile/bottom_tabs.cljs |
Adds native graph update/action listeners and refines search/tab event handling. |
src/main/frontend/components/repo.cljs |
Keeps mobile graph download popup open while starting remote graph download. |
shadow-cljs.edn |
Adds optional HTTPS Shadow CLJS dev server configuration. |
scripts/src/logseq/tasks/dev/mobile.clj |
Adds mobile HTTPS certificate generation and updates iOS/Android mobile dev tasks. |
ios/App/App/Utils.swift |
Adds debug-only server trust handling for HTTPS dev server loading. |
ios/App/App/UILocalPlugin.swift |
Improves date picker completion/cancel handling and multiline alert drops. |
ios/App/App/SharedWebViewController.swift |
Detaches shared webview using the actual current parent. |
ios/App/App/NativeTopBarPlugin.swift |
Disables nav bar hide/show animation. |
ios/App/App/NativeBottomSheetPlugin.swift |
Waits for JS content readiness before clearing dismissal snapshot. |
ios/App/App/LiquidTabsStore.swift |
Adds native graph state, refresh state, and web tab transition readiness tracking. |
ios/App/App/LiquidTabsRootView.swift |
Adds native graphs tab UI and revises iOS search/tab navigation flows. |
ios/App/App/LiquidTabsPlugin.swift |
Adds native graph bridge methods/events and tab readiness support. |
ios/App/App/AppDelegate.swift |
Refines native stack bookkeeping, JS-originated pop suppression, and route observation. |
docs/develop-logseq-on-mobile.md |
Updates iOS mobile dev instructions for HTTPS Shadow CLJS workflow. |
bb.edn |
Adds a Babashka task for generating the mobile HTTPS certificate. |
.gitignore |
Ignores generated local SSL development artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation