Skip to content

Eliminates one class of frequently-encountered timing issues with tests #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Eliminates one class of frequently-encountered timing issues with tests #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spec/inputs/tcp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def get_port
end

insist { events.length } == event_count
events = events.sort_by {|e| e.get("message")} # the ordering of events in the queue is highly timing-dependent
event_count.times do |i|
event = events[i]
insist { event.get("message") } == "#{i} ☹"
Expand Down Expand Up @@ -106,6 +107,7 @@ def get_port
end

insist { events.length } == event_count
events = events.sort_by {|e| e.get("message")} # the ordering of events in the queue is highly timing-dependent
event_count.times do |i|
insist { events[i].get("message") } == "#{i} ☹"
insist { events[i].get("host") } == "1.2.3.4"
Expand Down Expand Up @@ -231,6 +233,7 @@ def get_port
(1..event_count).map{queue.pop}
end

events = events.sort_by {|e| e.get("idx")} # the ordering of events in the queue is highly timing-dependent
events.each_with_index do |event, idx|
insist { event.get("hello") } == data["hello"]
insist { event.get("foo").to_a } == data["foo"] # to_a to cast Java ArrayList produced by JrJackson
Expand Down