fix retention worker on compressed chunks#130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the log retention cleanup logic to improve efficiency and reliability, especially when handling compressed chunks in TimescaleDB. The main change is the removal of explicit chunk decompression in favor of using TimescaleDB's native
drop_chunksfor maximum retention and a new batching strategy for deleting logs per day, which avoids decompressing chunks manually. The reporting interfaces and logic are updated accordingly.Retention logic refactor and batching improvements:
findCompressedChunksToDecompress,decompressChunk, and all tracking of decompressed chunks. [1] [2] [3] [4] [5]batchDeleteLogsmethod that deletes logs in daily time windows, which works efficiently with compressed chunks and avoids large transactions.Retention execution flow changes:
executeRetentionForOrganizationto use the new batching strategy, removing the need to decompress chunks before deleting logs. [1] [2]executeRetentionForAllOrganizationsto:drop_chunksfor organizations with the maximum retention (no per-row deletes needed).API and reporting updates:
RetentionExecutionResultandRetentionExecutionSummaryinterfaces, as chunk decompression is no longer part of the process. [1] [2] [3] [4]chunksDroppedandretentionGroupsto the summary logs for better observability of the new process.These changes make the retention cleanup process safer, more scalable, and better aligned with TimescaleDB's best practices.