Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/experience/src/components/IdentifierRegisterForm/use-register-with-username.ts | 📈 +1.15 KB |
| packages/experience/src/constants/env.ts | 📈 +149 Bytes |
| packages/experience/src/containers/VerificationCode/use-register-flow-code-verification.ts | 📈 +283 Bytes |
| packages/experience/src/containers/VerificationCode/use-sign-in-flow-code-verification.ts | 📈 +44 Bytes |
| packages/experience/src/hooks/use-sie.ts | 📈 +3.88 KB |
| packages/experience/src/pages/RegisterPassword/index.tsx | 📈 +38 Bytes |
| packages/experience/src/pages/VerificationCode/index.tsx | 📈 +75 Bytes |
| packages/experience/vite.config.ts | 📈 +464 Bytes |
7525149 to
7d4b428
Compare
dfe66bf to
759d3fd
Compare
241003a to
7f85f16
Compare
wangsijie
approved these changes
Mar 19, 2025
759d3fd to
64aa695
Compare
7f85f16 to
e26d414
Compare
64aa695 to
0f7413c
Compare
e26d414 to
89a21e2
Compare
Base automatically changed from
simeng-log-10890-experience-api-update-registration-event-to-handle-multiple
to
master
March 24, 2025 03:25
refactor the verification code sign-in and sign-up error handling logic.
remove verification code method assertion
fix ut
add some comments
update username registraction handler, directly submit the interaction is password is not enabled for sign-up
89a21e2 to
8a38d05
Compare
simplify react hook dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the experience app to support the newly introduced
secondaryIdentifierssettings in the sign-up flow.Key changes
signUp.identifieras the primary sign-up method for the initial registration formsignUp.secondaryIdentifierssettings.Other updates
This PR also includes significant updates to the username registration flow, aligning it with the recent changes in sign-in experience settings:
usernamewas set as a sign-up identifier. This restriction has been removed in the latest sign-in experience updates. See PR.isDevFeaturesEnabledenv variables reading logic update in PRimport.metawill throw an error.process.envtill we migrate jest to vitest.Testing
test locally
Checklist
.changeset