fix(phrases): improve wording of "existing account?" question #7172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/phrases-experience/src/locales/en/description.ts | 📈 +1 Bytes |
| packages/phrases-experience/src/locales/en/secondary.ts | 📈 +1 Bytes |
nickdaugherty
force-pushed
the
fix/existing-account-english-wording
branch
4 times, most recently
from
602a354 to
7d49097
Compare
darcyYe
changed the title
Contributor
|
Thanks for your contribution! |
darcyYe
changed the title
Member
|
The commit message should be "phrases", though |
Contributor
|
Our CI is reporting an error. Could you please update this commit message? For example, change it to: 'fix(phrases): improve en i18n content'. |
nickdaugherty
force-pushed
the
fix/existing-account-english-wording
branch
from
7d49097 to
f315c5d
Compare
Contributor
Author
|
No problem, commit message updated. Hopefully that does the trick 🤞 |
charIeszhao
approved these changes
Mar 27, 2025
wangsijie
approved these changes
Mar 27, 2025
Contributor
update "fix(phrases): Improve en i18n content" to be "fix(phrases): improve en i18n content", in our commit lint rules, we do not accept commit message with a capitalized letter. |
"have" reads better in English
nickdaugherty
force-pushed
the
fix/existing-account-english-wording
branch
from
f315c5d to
96b8438
Compare
Contributor
Author
|
That's an interesting rule 😅 . Well I updated my commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small improvement to the wording of the "existing account" question on login prompts. Changes "Already had an account?" to "Already have an account?".
This is my first contribution to Logto so let me know if I did anything wrong!
Testing
Text-only change so didn't set up a local env
Checklist
.changeset