fix(phrases): fix i18n translations in regional variation locales #7210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/phrases/src/locales/pl-pl/errors/one-time-token.ts | 📈 +33 Bytes |
| packages/phrases/src/locales/pl-pl/translation/admin-console/mfa.ts | 📈 +48 Bytes |
| packages/phrases/src/locales/pl-pl/translation/admin-console/security.ts | 📈 +287 Bytes |
| packages/phrases/src/locales/pl-pl/translation/admin-console/tabs.ts | 📈 +9 Bytes |
| packages/phrases/src/locales/pt-br/errors/one-time-token.ts | 📈 +27 Bytes |
| packages/phrases/src/locales/pt-br/translation/admin-console/mfa.ts | 📈 +35 Bytes |
| packages/phrases/src/locales/pt-br/translation/admin-console/security.ts | 📈 +250 Bytes |
| packages/phrases/src/locales/pt-br/translation/admin-console/tabs.ts | 📈 +22 Bytes |
| packages/phrases/src/locales/pt-pt/errors/one-time-token.ts | 📈 +27 Bytes |
| packages/phrases/src/locales/pt-pt/translation/admin-console/mfa.ts | 📈 +41 Bytes |
| packages/phrases/src/locales/pt-pt/translation/admin-console/security.ts | 📈 +279 Bytes |
| packages/phrases/src/locales/pt-pt/translation/admin-console/tabs.ts | 0 Bytes |
| packages/phrases/src/locales/tr-tr/errors/one-time-token.ts | 📈 +21 Bytes |
| packages/phrases/src/locales/tr-tr/translation/admin-console/mfa.ts | 📈 +70 Bytes |
| packages/phrases/src/locales/tr-tr/translation/admin-console/security.ts | 📈 +229 Bytes |
| packages/phrases/src/locales/tr-tr/translation/admin-console/tabs.ts | 📈 +3 Bytes |
| packages/phrases/src/locales/zh-hk/errors/one-time-token.ts | 📈 +12 Bytes |
| packages/phrases/src/locales/zh-hk/translation/admin-console/mfa.ts | 📈 +5 Bytes |
| packages/phrases/src/locales/zh-hk/translation/admin-console/security.ts | 0 Bytes |
| packages/phrases/src/locales/zh-tw/errors/one-time-token.ts | 0 Bytes |
| packages/phrases/src/locales/zh-tw/translation/admin-console/mfa.ts | 📈 +3 Bytes |
| packages/phrases/src/locales/zh-tw/translation/admin-console/security.ts | 📈 +6 Bytes |
| packages/phrases/src/locales/zh-tw/translation/admin-console/tabs.ts | 📈 +4 Bytes |
simeng-li
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect i18n translations in regional variation locales.
Previously there was a bug in my local
translatepackage (fixed in #7164). And thus the translations being generated for regional variation locales (e.g. pt-BR) at that time were impacted (#7163).Testing
Locally tested
Checklist
.changeset