fix(account): clarify two-step verification toggle label#8792
Merged
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/clarify-two-step-toggle-label.md | 📉 -124 Bytes |
| packages/account/src/pages/Security/MfaSection/index.tsx | 📉 -150 Bytes |
| packages/phrases-experience/src/locales/ar/account-center.ts | 📉 -75 Bytes |
| packages/phrases-experience/src/locales/cs/account-center.ts | 📉 -68 Bytes |
| packages/phrases-experience/src/locales/de/account-center.ts | 📉 -70 Bytes |
| packages/phrases-experience/src/locales/en/account-center.ts | 📉 -64 Bytes |
| packages/phrases-experience/src/locales/es/account-center.ts | 📉 -71 Bytes |
| packages/phrases-experience/src/locales/fr/account-center.ts | 📉 -77 Bytes |
| packages/phrases-experience/src/locales/it/account-center.ts | 📉 -71 Bytes |
| packages/phrases-experience/src/locales/ja/account-center.ts | 📉 -68 Bytes |
| packages/phrases-experience/src/locales/ko/account-center.ts | 📉 -58 Bytes |
| packages/phrases-experience/src/locales/pl-pl/account-center.ts | 📉 -69 Bytes |
| packages/phrases-experience/src/locales/pt-br/account-center.ts | 📉 -72 Bytes |
| packages/phrases-experience/src/locales/pt-pt/account-center.ts | 📉 -72 Bytes |
| packages/phrases-experience/src/locales/ru/account-center.ts | 📉 -99 Bytes |
| packages/phrases-experience/src/locales/th/account-center.ts | 📉 -121 Bytes |
| packages/phrases-experience/src/locales/tr-tr/account-center.ts | 📉 -65 Bytes |
| packages/phrases-experience/src/locales/uk-ua/account-center.ts | 📉 -97 Bytes |
| packages/phrases-experience/src/locales/zh-cn/account-center.ts | 📉 -55 Bytes |
| packages/phrases-experience/src/locales/zh-hk/account-center.ts | 📉 -55 Bytes |
| packages/phrases-experience/src/locales/zh-tw/account-center.ts | 📉 -58 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves UX ambiguity on the Account Security page by changing the 2-step verification toggle label from an action-based phrase (“Turn on/off …”) to a neutral, state-independent feature name (“2-step verification”), aligning the text with the toggle’s on/off meaning (Fixes #8791).
Changes:
- Replaced the conditional “Turn on/off 2-step verification” toggle title with a neutral “2-step verification” label.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
charIeszhao
approved these changes
May 13, 2026
gao-sun
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8791
Testing