Skip to content

fix(account): redirect expired sessions without error flash#8830

Merged
wangsijie merged 2 commits into
masterfrom
sijie-fix-account-center-expired-session-redirect
May 21, 2026
Merged

fix(account): redirect expired sessions without error flash#8830
wangsijie merged 2 commits into
masterfrom
sijie-fix-account-center-expired-session-redirect

Conversation

@wangsijie
Copy link
Copy Markdown
Contributor

Summary

  • Automatically redirect expired Account Center sessions to sign-in behind the loading state.
  • Keep the manual sign-in error action only as a fallback when automatic redirect fails.
  • Add coverage for the expired session redirect flow.

Closes #8825

Testing

Unit tests

Copilot AI review requested due to automatic review settings May 19, 2026 04:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

COMPARE TO master

Total Size Diff 📈 +3.73 KB

Diff by File
Name Diff
.changeset/soft-plums-return.md 📈 +116 Bytes
packages/account/src/pages/SessionExpired/index.test.tsx 📈 +2.92 KB
packages/account/src/pages/SessionExpired/index.tsx 📈 +713 Bytes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ea227e782

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/account/src/pages/SessionExpired/index.tsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@github-actions github-actions Bot added size/m and removed size/m labels May 21, 2026
@wangsijie wangsijie enabled auto-merge (squash) May 21, 2026 01:52
@wangsijie wangsijie merged commit be5fa48 into master May 21, 2026
34 checks passed
@wangsijie wangsijie deleted the sijie-fix-account-center-expired-session-redirect branch May 21, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

bug: Account Center briefly shows an error and redirects to sign-in with an active SDK session

4 participants