fix(phrases): correct Chinese translation of Passkey#8870
Merged
charIeszhao merged 1 commit intoMay 27, 2026
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/fix-passkey-zh-translation.md | 📈 +109 Bytes |
| packages/phrases-experience/src/locales/zh-cn/mfa.ts | 📈 +15 Bytes |
| packages/phrases-experience/src/locales/zh-hk/mfa.ts | 📈 +18 Bytes |
| packages/phrases-experience/src/locales/zh-tw/mfa.ts | 📈 +18 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Chinese locale MFA (multi-factor authentication) strings to use the more accurate “passkey” terminology (“通行密鑰/通行密钥”) instead of “通行證”.
Changes:
- Update WebAuthn/passkey display name across zh-TW, zh-HK, and zh-CN.
- Update passkey-related onboarding and verification descriptions (zh-TW, zh-HK).
- Update passkey creation/verification strings to consistently reference “通行密鑰/通行密钥”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/phrases-experience/src/locales/zh-tw/mfa.ts | Replaces passkey wording with “通行密鑰” in MFA strings and descriptions. |
| packages/phrases-experience/src/locales/zh-hk/mfa.ts | Replaces passkey wording with “通行密鑰” in MFA strings and descriptions. |
| packages/phrases-experience/src/locales/zh-cn/mfa.ts | Replaces passkey wording with “通行密钥” in MFA strings and descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rotempasharel1
changed the title
Contributor
Author
|
Thanks for the review. I also aligned the backup code wording in the touched zh-HK and zh-TW onboarding descriptions to |
rotempasharel1
force-pushed
the
fix/issue-8837-l10n-passkey
branch
from
4f12f62 to
261235b
Compare
simeng-li
requested review from
a team,
simeng-li and
wangsijie
and removed request for
a team
wangsijie
approved these changes
May 26, 2026
cursor
Bot
force-pushed
the
fix/issue-8837-l10n-passkey
branch
from
261235b to
25e3411
Compare
cursor
Bot
changed the title
Align zh-CN, zh-HK, and zh-TW MFA passkey wording with 通行密钥/通行密鑰. Fixes logto-io#8837 Co-authored-by: Rotem <rotem.paharel1@gmail.com>
cursor
Bot
force-pushed
the
fix/issue-8837-l10n-passkey
branch
from
25e3411 to
c4572ca
Compare
charIeszhao
approved these changes
May 27, 2026
gao-sun
approved these changes
May 27, 2026
Member
|
@rotempasharel1 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8837
This PR aligns the Chinese translations of “Passkey” in MFA-related experience phrases.
通行密钥for zh-CN通行密鑰for zh-HK and zh-TWThis replaces inconsistent translations such as
通行证and通行密碼.Testing
Not run. This PR only updates locale strings.
Checklist
.changeset