Change logs on failure#56
Merged
mirii1994 merged 1 commit intologzio:masterfrom May 10, 2020
Merged
Conversation
Logging error only if all retries fails
mirii1994
approved these changes
May 10, 2020
Contributor
mirii1994
left a comment
mirii1994
left a comment
There was a problem hiding this comment.
Thank you for your suggestion. Adding it to the code!
Contributor
Author
|
@mirii1994 Thanks! Any estimation regarding the next release of the package? |
Contributor
|
@hilsenrat Next couple of weeks. |
Contributor
Author
@mirii1994 Any estimation? I see that v3.0.0 wasn't published to pypi yet. |
Contributor
|
@hilsenrat it's out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one of the configured tries is failing, so the logger would only throw warning and not error.
In case of all tries failed, and the logs has to be written to the disk, it'll be logged as an error.
What do you think?