Chapter 07 Sets 7.3 isSubsetOf

[rosald]

hi
the ‘isSubsetOf’ method is some kind of lengthy
it may be clear like following

isSubsetOf(otherSet) {
if (this.size() > otherSet.size()) {
return false;
}
return this.values().every(value => otherSet.has(value));
}

or remain 'isSubset' variable

const isSubset = this.values().every(value => otherSet.has(value));
return isSubset;

[Jeffzholy]

agree with you, and it could be shorter and cleaner:

isSubsetOf(otherSet) {
    const values = this.values();

    return values.every((value) => otherSet.has(value));
  }

I will raise a PR on this

[Jeffzholy]

@loiane #191

[loiane]

@Jeffzholy thanks, merged!