menu_story: add min_w to popup-menu to avoid resize on shortcut load#2320
Merged
madcodelife merged 1 commit intolongbridge:mainfrom Apr 30, 2026
Merged
Conversation
Member
|
Thanks. |
AzureZee
pushed a commit
to AzureZee/gpui-component
that referenced
this pull request
Apr 30, 2026
…ongbridge#2320) ## Description Keyboard shortcuts in the popup menu caused the component to resize after opening. This change adds a minimum width to prevent the layout shift and keep the popup menu size stable. ## Screenshot ### Before https://github.com/user-attachments/assets/b535fc43-c1eb-4b93-b108-cc7f01c16371 ### After https://github.com/user-attachments/assets/c5ee83b4-7ff6-4512-a0cb-9098b99cf78e ## Break Changes None ## Checklist - [x] I have read the [CONTRIBUTING](../CONTRIBUTING.md) document and followed the guidelines. - [x] Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate. - [x] Passed `cargo run` for story tests related to the changes. - [] Tested macOS, Windows and Linux platforms performance (if the change is platform-specific)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keyboard shortcuts in the popup menu caused the component to resize after opening. This change adds a minimum width to prevent the layout shift and keep the popup menu size stable.
Screenshot
Before
Ekran.Kaydi.2026-04-30.051436.mp4
After
Ekran.Kaydi.2026-04-30.051511.mp4
Break Changes
None
Checklist
cargo runfor story tests related to the changes.