refactor(fundamental): move etf_asset_allocation from QuoteContext to FundamentalContext#536
Merged
Merged
Conversation
…ontext Relocate the API and its types (AssetAllocationResponse / Group / Item, HoldingDetail, ElementType) to the fundamental module across all languages: - Rust: types/method moved to fundamental, blocking wrapper moved to FundamentalContextSync - Python: classes registered under fundamental module; method on FundamentalContext / AsyncFundamentalContext; openapi.pyi updated - Node.js: etfAssetAllocation now on FundamentalContext; index.d.ts/index.js regenerated - C: lb_quote_context_etf_asset_allocation → lb_fundamental_context_etf_asset_allocation; FFI types moved to fundamental_context; longbridge.h regenerated - C++: method moved to fundamental::FundamentalContext; types moved to namespace fundamental Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #535 (merged with the API on
QuoteContext): relocateetf_asset_allocationand its types (AssetAllocationResponse/AssetAllocationGroup/AssetAllocationItem,HoldingDetail,ElementType) to the fundamental module across all languages.fundamental; blocking wrapper moved toFundamentalContextSyncFundamentalContext/AsyncFundamentalContext;openapi.pyiupdatedetfAssetAllocationnow onFundamentalContext;index.d.ts/index.jsregeneratedlb_quote_context_etf_asset_allocation→lb_fundamental_context_etf_asset_allocation; FFI types moved tofundamental_context;longbridge.hregeneratedfundamental::FundamentalContext; types moved tonamespace fundamental[Unreleased]entry updated accordinglyBreaking change note
QuoteContext::etf_asset_allocationwas only on main briefly (unreleased), so moving it pre-release avoids shipping it in the wrong context.Verification
cargo clippy --all --all-features: cleancargo +nightly fmt --all: applied-fsyntax-onlyQQQ.USreturns all four allocation groups)🤖 Generated with Claude Code