fix(#127): stamp filename on CC transactions before card grouping#128
Merged
fix(#127): stamp filename on CC transactions before card grouping#128
Conversation
CC transactions with empty tx.filename could not be looked up in pdf_card_numbers, causing CCGroupingService to bucket them under 'unknown'. Backfill tx.filename from extraction.source_file.name in _build_grouping_inputs() before extending all_cc_txns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #127
_build_grouping_inputs(), backfilltx.filenamefromextraction.source_file.namefor any CC transaction with an empty filename before extendingall_cc_txnsCCGroupingServicefrom falling back to'unknown'whenpdf_card_numbers.get(tx.filename)returnsNoneTest plan
bank_statements_unknown.*files gone;bank_statements_9459row count increases from 15 → 22 (7 previously misrouted transactions now correctly attributed)