chore: wire git hooks setup into Makefile and CONTRIBUTING#187
Merged
chore: wire git hooks setup into Makefile and CONTRIBUTING#187
Conversation
Add `git config core.hooksPath .githooks` to the `make setup` target and to the CONTRIBUTING.md local setup steps so new clones automatically activate the pre-push hook that blocks direct pushes to main.
github-actions
Bot
added
chore
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Ensures new clones automatically activate the
.githooks/pre-pushhook that blocks direct pushes tomain. Previouslygit config core.hooksPath .githookswas a manual step with no documentation.Changes
Makefile—make setupnow runsgit config core.hooksPath .githooksCONTRIBUTING.md— local setup steps include thegit configcommand with a note explaining what it doesType
Testing
Checklist
Downstream impact
bankstatements_core(exported class, function, or exception)