Release v0.9.3 #14
Release v0.9.3 #14
Conversation
Merge release/0.9.2 back to develop
There was a problem hiding this comment.
Pull Request Overview
This PR implements validation for Sparkplug namespace elements (Host Application ID, Group ID, Edge Node ID, Device ID) by centralizing the validation logic into a reusable method. The version is bumped to 0.9.3 to reflect these improvements.
- Centralized namespace element validation using
SparkplugNamespace.ValidateNamespaceElement() - Added validation for Group ID, Edge Node ID, and Device ID in command publishing methods
- Comprehensive test coverage for the new validation regex and method
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SparklerNet/SparklerNet.csproj | Version bump from 0.9.2 to 0.9.3 |
| SparklerNet/HostApplication/SparkplugHostApplication.cs | Replaced local regex validation with centralized ValidateNamespaceElement() method, added validation for command message parameters |
| SparklerNet/Core/Topics/SparkplugTopicParser.cs | Removed unused System.Globalization import |
| SparklerNet/Core/Constants/SparkplugNamespace.cs | Added ValidateNamespaceElement() method and NamespaceElementRegex() for centralized validation |
| SparklerNet.Tests/Core/Constants/SparkplugNamespaceTests.cs | Added comprehensive tests for the new regex validation logic |
| SparklerNet.Samples/SimpleHostApplication.cs | Improved logging message with structured logging and added suppression attribute |
| README.md | Updated roadmap to reflect completed validation features and corrected typo |
| Array_Types.md | Removed documentation file (potentially relocated or consolidated) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| string deviceId, Payload payload) | ||
| { | ||
| // TODO: Validate the group ID and edge node ID and the payload. | ||
| // Validate the group ID and edge node ID and the payload. |
There was a problem hiding this comment.
The comment states 'Validate the group ID and edge node ID and the payload' but the code also validates deviceId. The comment should be updated to 'Validate the group ID, edge node ID, device ID and the payload' to accurately reflect all parameters being validated.
| // Validate the group ID and edge node ID and the payload. | |
| // Validate the group ID, edge node ID, device ID and the payload. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR merges release/v0.9.3 into main for the official v0.9.3 release.\n\n## Changes\n- Version updated to 0.9.3\n\nPlease review before merging. This PR should NOT be automatically merged and requires manual review.