Feature: Increase Task Delays by 3 Seconds#2
Conversation
longluubao
left a comment
There was a problem hiding this comment.
This pull request successfully implements the requested changes to increase the delay and period of tasks TASK_0 through TASK_4 in RTOS-Scheduler/Core/Src/main.c by 3 seconds (3000ms). The code changes are clear and directly address the requirement. This modification will adjust the scheduling behavior of the RTOS tasks as intended. The changes appear to be correct. I recommend merging this pull request after a thorough manual review by a team member to ensure no unintended side effects on the RTOS behavior due to increased task delays.
longluubao
left a comment
There was a problem hiding this comment.
Comparison with Pull Request #1 ('MCP-Testing-1'):
- Pull Request #1 aimed to update task times in
main.cby adding 1000ms to each task's delay and period, originating from thedevmate_mcpbranch. - This Pull Request #2 ('Feature: Increase Task Delays by 3 Seconds') also modifies task delays and periods in
RTOS-Scheduler/Core/Src/main.c, but it increases them by 3000ms (3 seconds) and originates from thefeature/task_updatedbranch.
Both PRs address similar functionality but with different magnitudes of change and from distinct feature branches.
|
Here's a summary of the changes in Pull Request #2:
|
This pull request increases the delay and period for tasks TASK_0 through TASK_4 in
RTOS-Scheduler/Core/Src/main.cby 3000 milliseconds (3 seconds). This change was made to demonstrate modification of task scheduling parameters.