Skip to content

Feature: Increase Task Delays by 3 Seconds#2

Open
longluubao wants to merge 3 commits into
mainfrom
feature/task_updated
Open

Feature: Increase Task Delays by 3 Seconds#2
longluubao wants to merge 3 commits into
mainfrom
feature/task_updated

Conversation

@longluubao
Copy link
Copy Markdown
Owner

This pull request increases the delay and period for tasks TASK_0 through TASK_4 in RTOS-Scheduler/Core/Src/main.c by 3000 milliseconds (3 seconds). This change was made to demonstrate modification of task scheduling parameters.

Copy link
Copy Markdown
Owner Author

@longluubao longluubao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request successfully implements the requested changes to increase the delay and period of tasks TASK_0 through TASK_4 in RTOS-Scheduler/Core/Src/main.c by 3 seconds (3000ms). The code changes are clear and directly address the requirement. This modification will adjust the scheduling behavior of the RTOS tasks as intended. The changes appear to be correct. I recommend merging this pull request after a thorough manual review by a team member to ensure no unintended side effects on the RTOS behavior due to increased task delays.

Copy link
Copy Markdown
Owner Author

@longluubao longluubao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparison with Pull Request #1 ('MCP-Testing-1'):

  • Pull Request #1 aimed to update task times in main.c by adding 1000ms to each task's delay and period, originating from the devmate_mcp branch.
  • This Pull Request #2 ('Feature: Increase Task Delays by 3 Seconds') also modifies task delays and periods in RTOS-Scheduler/Core/Src/main.c, but it increases them by 3000ms (3 seconds) and originates from the feature/task_updated branch.

Both PRs address similar functionality but with different magnitudes of change and from distinct feature branches.

@longluubao
Copy link
Copy Markdown
Owner Author

Here's a summary of the changes in Pull Request #2:

  • Commit b2a69f052b10b023b821811830467576e7b9f8b9: Updated TIMER_CYCLE to 50 in RTOS-Scheduler/Core/Inc/timer.h.
  • Commit 07a0432b7be8c760f870b74871aed3fcd0af9450: Updated SCH_Add_Task parameters in button.c.
  • Commit 9963a38600943dbcd6385748660c2745f9478959: Increased task delays by 3 seconds in main.c.
  • Commit 564182ae1efb6096a005c2552fbef9764b7a1747: Initial commit for "RTOS Implementation using STM32F103C6".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant