[#4] [FRONTEND] As a user, I can sign-up using my email and password#28
Merged
[#4] [FRONTEND] As a user, I can sign-up using my email and password#28
Conversation
longnd
force-pushed
the
feature/sign-up-front-end
branch
from
951f557 to
57a9eaf
Compare
longnd
force-pushed
the
feature/sign-up-front-end
branch
from
57a9eaf to
0bf017a
Compare
hanam1ni
reviewed
Apr 16, 2021
Collaborator
hanam1ni
left a comment
hanam1ni
left a comment
There was a problem hiding this comment.
A few comments and it would be easier for the next reviewer if we can separate the rename changes to another PR.
rosle
approved these changes
Apr 19, 2021
Collaborator
rosle
left a comment
rosle
left a comment
There was a problem hiding this comment.
Other than Micky's comment. Looking good to me 👍 ✅
Collaborator
olivierobert
left a comment
olivierobert
left a comment
There was a problem hiding this comment.
Ideally, the renaming of the project and set up of Bootstrap should be have been done in separate PRs to avoid having a PR with 80+ file changes 🙈
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4
What happened
lib/gcraper_web&lib/gcraper_web_web)Insight
Proof Of Work