[#6][#7] As a user, I can sign-in using my email and password | Front-end & back-end#30
Merged
[#6][#7] As a user, I can sign-in using my email and password | Front-end & back-end#30
Conversation
987affc to
df9e0cc
Compare
875ca80 to
94beb71
Compare
bab02dc to
6a44cc1
Compare
ab0aace to
3a83a92
Compare
e1fcf24 to
300a70e
Compare
300a70e to
7f64064
Compare
rosle
reviewed
Sep 13, 2021
Base automatically changed from
chore/refactor-the-account-context
to
develop
September 15, 2021 09:02
d8e7526 to
a0971dd
Compare
hanam1ni
reviewed
Sep 20, 2021
Collaborator
hanam1ni
left a comment
There was a problem hiding this comment.
Small comments, the rest LGTM 👍
hanam1ni
approved these changes
Sep 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6, Resolves #7
What happened
:ensure_auth- when applied on a route, the user must log in before accessing:skip_after_auth- when applied on a route, the route will be skipped if the user already logged in and redirects the user to the dashboard page.Insight
To authenticate the user, this PR uses the guardian package (Github). It provides:
EnsureAuthenticatedPlug to force the user to log in before accessing a routeelixir-gscraper/lib/gscraper/guardian/authentication.ex
Lines 1 to 5 in 300a70e
elixir-gscraper/lib/gscraper/guardian/error_handler.ex
Lines 1 to 6 in 300a70e
Proof Of Work
Screen.Recording.2021-09-12.at.10.13.41.mov