feat(Layout): Aside, Footer & Header now support border* props #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laraharrow
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 93.59% 93.69% +0.09%
==========================================
Files 404 405 +1
Lines 6702 6739 +37
Branches 2152 2168 +16
==========================================
+ Hits 6273 6314 +41
+ Misses 429 425 -4
Continue to review full report at Codecov.
|
ghost
marked this pull request as draft
ghost
reviewed
Mar 10, 2021
ghost
suggested changes
Mar 10, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Can you add Storybook stories for Header, Aside & Footer so that snapshots are added for this feature (as well as upcoming ones)
packages/components/src/Layout/Semantics/semanticBorderHelper.ts
Outdated
Show resolved
Hide resolved
ghost
marked this pull request as ready for review
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
2 times, most recently
from
6323476 to
75b05b9
Compare
ghost
suggested changes
Mar 12, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Functionality looks great!
Had some comments about Storybook & test coverage adjustments I'd like to see.
packages/components/src/Layout/Semantics/Story/ExamplePage.story.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Layout/Semantics/Story/Semantics.story.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Layout/Semantics/semanticBorderHelper.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Layout/Semantics/semanticBorderHelper.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Layout/Semantics/semanticBorderHelper.ts
Outdated
Show resolved
Hide resolved
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
2 times, most recently
from
33d79f9 to
9729dd3
Compare
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
from
adcddef to
5cdf15d
Compare
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
from
5cdf15d to
513e4f0
Compare
ghost
suggested changes
Mar 15, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Two really tiny nits on test-coverage / stories and then this should be good-to-go.
packages/components/src/Layout/Semantics/Story/Semantics.story.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Layout/Semantics/semanticBorderHelper.test.tsx
Outdated
Show resolved
Hide resolved
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
2 times, most recently
from
b5fc877 to
e195fef
Compare
laraharrow
force-pushed
the
lara/Layout-border/1519
branch
from
e195fef to
005a777
Compare
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Please check the following items are addressed in your pull request (or are not applicable)
Image snapshots (choose one)
Documentation updated (choose one)