Skip to content

feat: support custom environment prefixes (#999) #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat: support custom environment prefixes (#999) #1028

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a75e232
feat: support custom environment prefixes (#999)
ianatkinson-ee Mar 21, 2022
fb27318
Merge branch 'main' into main
ianatkinson-ee Mar 22, 2022
a78a325
Merge branch 'main' into main
ianatkinson-ee Apr 5, 2022
8bf2361
Merge branch 'main' into main
ianatkinson-ee Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/looker_sdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,24 +38,27 @@


def _settings(
config_file: str, section: Optional[str] = None
config_file: str,
env_prefix: str = constants.environment_prefix,
section: Optional[str] = None
) -> api_settings.ApiSettings:
return api_settings.ApiSettings(
filename=config_file,
section=section,
sdk_version=constants.sdk_version,
env_prefix=constants.environment_prefix,
env_prefix=env_prefix,
)


def init31(
config_file: str = "looker.ini",
env_prefix: str = constants.environment_prefix,
section: Optional[str] = None,
config_settings: Optional[api_settings.ApiSettings] = None,
) -> methods31.Looker31SDK:
"""Default dependency configuration"""
settings = (
_settings(config_file, section) if config_settings is None else config_settings
_settings(config_file, env_prefix, section) if config_settings is None else config_settings
)
settings.is_configured()
transport = requests_transport.RequestsTransport.configure(settings)
Expand All @@ -70,12 +73,13 @@ def init31(

def init40(
config_file: str = "looker.ini",
env_prefix: str = constants.environment_prefix,
section: Optional[str] = None,
config_settings: Optional[api_settings.ApiSettings] = None,
) -> methods40.Looker40SDK:
"""Default dependency configuration"""
settings = (
_settings(config_file, section) if config_settings is None else config_settings
_settings(config_file, env_prefix, section) if config_settings is None else config_settings
)
settings.is_configured()
transport = requests_transport.RequestsTransport.configure(settings)
Expand Down