chore: fix build #1382
Merged
chore: fix build #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treshugart
commented
Oct 13, 2023
| "build:cjs": "lerna exec --stream 'BABEL_ENV=build_cjs babel src --root-mode upward --out-dir lib --source-maps --extensions .ts,.tsx --no-comments'", | ||
| "build:es": "lerna exec --stream 'BABEL_ENV=build babel src --root-mode upward --out-dir lib/esm --source-maps --extensions .ts,.tsx --no-comments'", | ||
| "build:ts": "lerna exec --stream --sort 'tsc -b tsconfig.build.json'", | ||
| "build:cjs": "lerna exec --ignore @internal/* --stream 'BABEL_ENV=build_cjs babel src --root-mode upward --out-dir lib --source-maps --extensions .ts,.tsx --no-comments'", |
Contributor
Author
There was a problem hiding this comment.
We have to have some sort of marker to filter unwanted workspaces. We can't use private because we have private workspaces in packages/ that need to be built. And we can't target just the packages/ folder because Lerna.
Moving away from root build scripts, and defining them in pacakges and using --if-present when running them would be the correct way to do this, I think.
josephaxisa
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue causing a broken build.
We should probably run the build in CI (part of
npm test) as it would have surfaced the error in the original PR.The core problem was lerna wasn't filtering out workspaces we don't want to build.
Ideally we would use
npx -w packages, but NPM doesn't topologically sort and we'd have to declare each workspace in order of dependence manually. See: npm/cli#4139. NPM moves so slowly and has a general distaste - it seems - for adopting useful behavior (see pnpm), I wouldn't hold our breath. Lerna make sense for now. Hooooooowever, onto the next pointTo move away from Lerna and Yarn, we'd need to do a combo of TypeScript project references (to remove the need for
--sortwhen runningtsc) and definebuildscripts in each package that needs to build, then use `npm run build --if-present --workspaces. We really shouldn't be defining root scripts that operate on workspaces.