Skip to content

chore: fix build #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: fix build #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apix-files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@looker/apix-files",
"name": "@internal/apix-files",
"version": "21.0.11",
"description": "Looker File Server for API Explorer",
"main": "lib/index.js",
Expand Down
3 changes: 2 additions & 1 deletion bin/looker-resources-index/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "looker-resources-index",
"name": "@internal/looker-resources-index",
"version": "0.0.0",
"description": "A listing of Looker-related resources, and some automation for publishing the listing in consumable formats",
"main": "src/resource-data/resources.ts",
"private": true,
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"view": "yarn api-explorer",
"wipe": "rm -rf api spec",
"build": "rm -Rf packages/*/lib && run-p -c build:*",
"build:cjs": "lerna exec --stream 'BABEL_ENV=build_cjs babel src --root-mode upward --out-dir lib --source-maps --extensions .ts,.tsx --no-comments'",
"build:es": "lerna exec --stream 'BABEL_ENV=build babel src --root-mode upward --out-dir lib/esm --source-maps --extensions .ts,.tsx --no-comments'",
"build:ts": "lerna exec --stream --sort 'tsc -b tsconfig.build.json'",
"build:cjs": "lerna exec --ignore @internal/* --stream 'BABEL_ENV=build_cjs babel src --root-mode upward --out-dir lib --source-maps --extensions .ts,.tsx --no-comments'",
Copy link
Contributor Author

@treshugart treshugart Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to have some sort of marker to filter unwanted workspaces. We can't use private because we have private workspaces in packages/ that need to be built. And we can't target just the packages/ folder because Lerna.

Moving away from root build scripts, and defining them in pacakges and using --if-present when running them would be the correct way to do this, I think.

"build:es": "lerna exec --ignore @internal/* --stream 'BABEL_ENV=build babel src --root-mode upward --out-dir lib/esm --source-maps --extensions .ts,.tsx --no-comments'",
"build:ts": "lerna exec --ignore @internal/* --stream --sort 'tsc -b tsconfig.build.json'",
"build-extensions": "lerna run bundle",
"dedupe:dev": "yarn-deduplicate -s fewer yarn.lock && yarn",
"dedupe:list": "yarn-deduplicate --list",
Expand Down