Conversation
gakonst
force-pushed
the
whitelist-tests
branch
from
6fef34f to
1be43b2
Compare
gakonst
changed the title
aupiff
suggested changes
Apr 10, 2019
| return CalculatePreciseFraction(frac, total, granular) | ||
| } | ||
|
|
||
| // frac is expressed in basis points |
Contributor
There was a problem hiding this comment.
This comment is now outdated due to your change.
aupiff
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When whitelist amounts were calculated in calculateShare, it'd proceed to call CalculatePreciseFraction. However,
CalculatePreciseFractionwas designed to not operate on billionths. Arguments are passed to it as billionths fromCalculateFractionin dposv3 . This PR fixed this bug introduced in b6975b1#diff-318c73cfec571e534f934a4aa0224decR41