Implement Dynamic Server Text Update & Add 'Show App Name' Setting #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that dynamically updates the server text based on user preferences. Key changes include:
New Functionality:
Added updateServerText function in BGData.swift for dynamic text updates in the main view controller.
User Setting Integration:
Integrated a new user setting showAppName in GeneralSettingsViewController.swift and UserDefaults.swift for toggling the display of the app's name.
Enum Extension:
Extended GeneralSettingsChangeEnum in AppStateController.swift to include showAppNameChange.
UI and Logic Updates:
Updated MainViewController.swift to use the new updateServerText function and handle the showAppNameChange setting.
Immediate Effect of Toggle:
If showAppName is toggled on, it will be immediately reflected in the GUI. When toggled off, Nightscout or Dexcom will be shown as the server text after the next BG update, depending on the source used.
These changes enhance the user experience by allowing the display of the app name based on user preference and streamline the server text update process. The immediate effect of the toggle provides a responsive interface for the users.