Align Fat/Protein order in TRC to Trio v0.6.0.51#524
Merged
marionbarker merged 2 commits intoloopandlearn:devfrom Mar 8, 2026
Merged
Align Fat/Protein order in TRC to Trio v0.6.0.51#524marionbarker merged 2 commits intoloopandlearn:devfrom
marionbarker merged 2 commits intoloopandlearn:devfrom
Conversation
Also display banner to notify users of the swap. Don't show again once dismissed and don't show for new users.
bjorkert
approved these changes
Feb 28, 2026
Contributor
bjorkert
left a comment
bjorkert
left a comment
There was a problem hiding this comment.
Clean, well-thought-out PR. Migration logic correctly distinguishes existing vs new users, banner only shows when fat/protein is enabled, and TODO cleanup dates are clear. LGTM.
marionbarker
approved these changes
Mar 8, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approved by code review and test.
Built onto phone with Loop URL selected. No banner seen.
Built onto phone with Trio URL and Fat/Protein enabled for meal. Banner shown on Remote Meal screen until user dismisses it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also display banner to notify users of the swap. Don't show again once dismissed and don't show for new users.