Skip to content

Fix NUKE_CERT variables to be case insensitive in bash #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marionbarker merged 3 commits into from
Mar 16, 2026
+5 −3
Merged

Fix NUKE_CERT variables to be case insensitive in bash #536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abeb008
Fix NUKE_CERT variables to be case insensitive in bash
bjorkert Mar 10, 2026
d8faedc
Add comment about the 68929{VAR,,} syntax
bjorkert Mar 16, 2026
a75fd64
Use tr for lower casecase
bjorkert Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/create_certs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ jobs:
id: set_output
run: |
CERT_STATUS_FILE="${{ github.workspace }}/fastlane/new_certificate_needed.txt"
ENABLE_NUKE_CERTS=${{ vars.ENABLE_NUKE_CERTS }}
# Convert to lowercase for case-insensitive comparison
ENABLE_NUKE_CERTS=$(echo "${{ vars.ENABLE_NUKE_CERTS }}" | tr '[:upper:]' '[:lower:]')
FORCE_NUKE_CERTS=$(echo "${{ vars.FORCE_NUKE_CERTS }}" | tr '[:upper:]' '[:lower:]')

if [ -f "$CERT_STATUS_FILE" ]; then
CERT_STATUS=$(cat "$CERT_STATUS_FILE" | tr -d '\n' | tr -d '\r') # Read file content and strip newlines
Expand All @@ -81,8 +83,8 @@ jobs:
exit 1
fi

# Check if vars.FORCE_NUKE_CERTS is not set to true
if [ vars.FORCE_NUKE_CERTS = "true" ]; then
# Check if FORCE_NUKE_CERTS is set to true
if [ "$FORCE_NUKE_CERTS" = "true" ]; then
echo "::warning::‼️ Nuking of certificates was forced because the repository variable FORCE_NUKE_CERTS is set to 'true'."
fi

Expand Down