Reorganize settings navigation and tab customization#553
Merged
marionbarker merged 10 commits intodevfrom Mar 19, 2026
Merged
Conversation
marionbarker
requested changes
Mar 18, 2026
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Almost approved by code review and test.
The screens navigation headers seem more consistent now.
- If a feature screen has a tab is in the toolbar, you use the toolbar to get to another screen.
- If the feature screen can only be reached via the Menu, you use a blue X at upper right to return to Menu
- The Settings screen uses an X at upper left to return to Menu
- The sub-screens in Settings use a
<at upper left to return to Settings - The exception is the Tab sub-screen
- The sub-screens in Settings use a
Please modify the Tab sub-screen to use the < at upper left to return to Settings.
Right now it uses a Done on upper right.
…d remove unused dismiss environment
# Conflicts: # LoopFollow/Settings/TabCustomizationModal.swift
bjorkert
approved these changes
Mar 18, 2026
Collaborator
|
Some Features (that are not selected as tabs) say "< Menu" and others say "<" and of course Statistics is a little different because it has "< Menu" and "Refresh". When Statistics is a tab, it does not have anything on navigation row - so can't hit refresh. (Do we need the refresh button?)
|
marionbarker
approved these changes
Mar 19, 2026
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Approved by Test.
This reorganization works as expected. IMO a big improvement.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simplify the tabs screen by removing modal-specific state and using standard dismiss/navigation behavior
Details