Skip to content

i18n: sync translations#60

Open
bastiaanv wants to merge 6 commits into
loopandlearn:mainfrom
bastiaanv:i18n/sync-translations
Open

i18n: sync translations#60
bastiaanv wants to merge 6 commits into
loopandlearn:mainfrom
bastiaanv:i18n/sync-translations

Conversation

@bastiaanv
Copy link
Copy Markdown
Collaborator

Used the translation file from OmniBLE as a base. Machine translated the rest using DeepL or AWS.
Also removed Hindi from the language list.

(used the translations file from current main, any translation changes from the open PR's are not included in this PR)

@marionbarker
Copy link
Copy Markdown
Contributor

Please add ko (Korean).

@bastiaanv
Copy link
Copy Markdown
Collaborator Author

Done!

@marionbarker
Copy link
Copy Markdown
Contributor

Test

I did a test build on a real phone. I see the new strings (found only in OmnipodKit but not in other repos) are still in English. The older strings are translated. I did a spot check of about 10 languages.

I tested Korean as well as the other languages with the same result.

I also looked at diffs from just 71f5c11 and compared the example of "has a low battery" for Romanian (ro) - which I know was recently adjusted. The version in this commit matches what is currently in lokalise for both MinimedKit and OmniKit.

Next step

I think the next step is to apply your machine translation tool to the final set of strings in OmnipodKit that are not translated.

@marionbarker
Copy link
Copy Markdown
Contributor

Test again

The new strings are now translated. Thanks so much @bastiaanv.

Copy link
Copy Markdown
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by code review and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants