Skip to content

Conversation

ssh24
Copy link
Contributor

@ssh24 ssh24 commented Apr 19, 2017

Revert back #246 due to loopback requiring loopback-connector as a default dependency through this module.

connect to strongloop/loopback-workspace#487

Add loopback-connector as peer dependencies (#246)

This reverts commit cc0b806.
@ssh24 ssh24 force-pushed the revert-246-fix-parameterized-sql branch from 738ee86 to a404089 Compare April 19, 2017 17:41
Copy link
Contributor

@loay loay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just make sure that `all tests pass before merging

@ssh24 ssh24 added the apex label Apr 19, 2017
@ssh24 ssh24 added this to the Sprint 34 - Apex milestone Apr 19, 2017
@ssh24 ssh24 merged commit 1b85e41 into master Apr 19, 2017
@ssh24 ssh24 deleted the revert-246-fix-parameterized-sql branch April 19, 2017 18:38
@ssh24 ssh24 removed the #review label Apr 19, 2017
kjdelisle pushed a commit that referenced this pull request May 15, 2017
 * Add docker setup (#256) (Sakib Hasan)
 * Allow explicit numeric datatype (#254) (Sakib Hasan)
 * Allow non-id serial properties (#198) (zbarbuto)
 * Revert PR #246 (#248) (Sakib Hasan)
 * Add loopback-connector as peer dependencies (#246) (Russ Tyndall)
 * Fix operations on ended transactions (zbarbuto)
 * dbdefaults: Cleanup InvalidDefault def after test (Kevin Delisle)
 * Reuse the data source to avoid too many clients (Raymond Feng)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants