Allow explicit numeric datatype #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh24
force-pushed
the
fix/explicit-numeric-datatype
branch
3 times, most recently
from
496ceae to
7014197
Compare
ssh24
force-pushed
the
fix/explicit-numeric-datatype
branch
from
7014197 to
7ebfb98
Compare
b-admike
reviewed
May 4, 2017
lib/migration.js
Outdated
| return colDefault ? (' DEFAULT ' + colDefault) : ''; | ||
| }; | ||
|
|
||
| // override this function from base connector to allow postgres |
There was a problem hiding this comment.
to allow postgres connector to
test/postgresql.test.js
Outdated
|
|
||
| it('should run migration', function(done) { | ||
| db.automigrate('PostWithBoolean', function() { | ||
| db.automigrate(['PostWithBoolean', 'Expense'], function() { |
There was a problem hiding this comment.
what does PostWithBoolean do?
There was a problem hiding this comment.
PostWithBoolean is another model attached to the same datasource. It was already there before for other tests. I only added the Expense model.
ssh24
force-pushed
the
fix/explicit-numeric-datatype
branch
from
8fc50a8 to
60fb48a
Compare
0candy
reviewed
May 4, 2017
lib/migration.js
Outdated
| return null; | ||
| } | ||
| var colLength = columnMetadata && columnMetadata.dataLength || | ||
| prop.length || prop.limit; |
There was a problem hiding this comment.
This should be indented one level?
ssh24
force-pushed
the
fix/explicit-numeric-datatype
branch
from
60fb48a to
9fe7aaa
Compare
loay
reviewed
May 4, 2017
lib/migration.js
Outdated
| // info on setting column specific properties | ||
| // i.e dataLength, dataPrecision, dataScale | ||
| // https://loopback.io/doc/en/lb3/Model-definition-JSON-file.html | ||
| if (colType && colLength) |
There was a problem hiding this comment.
I would refactor this since colType is a common condition:
if(colType) {
if (colLength) {
// return ..
}
if ( colPrecision && colScale) {
// return ...
}
}
ba5e80a to
a463388
Compare
kjdelisle
pushed a commit
that referenced
this pull request
May 15, 2017
* Add docker setup (#256) (Sakib Hasan) * Allow explicit numeric datatype (#254) (Sakib Hasan) * Allow non-id serial properties (#198) (zbarbuto) * Revert PR #246 (#248) (Sakib Hasan) * Add loopback-connector as peer dependencies (#246) (Russ Tyndall) * Fix operations on ended transactions (zbarbuto) * dbdefaults: Cleanup InvalidDefault def after test (Kevin Delisle) * Reuse the data source to avoid too many clients (Raymond Feng)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
connect to #250
Related issues
Checklist
guide