Stop executing query if transaction has ended #329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
sahilarora946
requested review from
jannyHou,
virkt25 and
zbarbuto
as code owners
2 tasks
|
Thanks for the PR - could you please fix up the commit message to satisfy the linter. |
added 3 commits
April 24, 2018 13:55
so that no further queries can be executed in the same transaction after rollback has been executed
…/github.com/sahilarora946/loopback-connector-postgresql into stop-executing-queries-on-ended-transaction * 'stop-executing-queries-on-ended-transaction' of https://github.com/sahilarora946/loopback-connector-postgresql: fix lint error set txid to null, so that no further queries can be executed in the same transaction
|
Created another pull request for this. Kindly ignore this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue described in #230
Related issues
#129
Refer to
rollbackfunction in https://github.com/zbarbuto/loopback-connector-postgresql/blob/1361460cea86fadd14a68aa8fe9c55f14ecb9a6d/lib/transaction.js#L58-L86After the
ROLLBACKis executed, callback will be sent to the event loop to be executed. Event loop can pick any of the available callbacks to execute. It can pick another function that can do database calls in the same transaction and because releaseConnection has not been called, the statement will execute.To stop the execution,
connection.txIdshould be set to null without waiting for the callback ofROLLBACKto be called