Skip to content

Stop executing query if transaction has ended #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Stop executing query if transaction has ended #329

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d38ac1
set txid to null, so that no further queries can be executed in the s…
Apr 24, 2018
c3ee5d7
fix lint error
Apr 24, 2018
200910a
set txid to null synchronously
Apr 24, 2018
0e4007c
fix lint error
Apr 24, 2018
78d79c5
Merge branch 'stop-executing-queries-on-ended-transaction' of https:/…
Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ function mixinTransaction(PostgreSQL) {
self.releaseConnection(connection, err);
cb(err);
});
//If we don't set txId to null and wait for the callback
//of ROLLBACK query to execute, another query can be executed in the
//same transaction because the callback will be called asynchronously
if (typeof connection.autorelease === 'function') {
connection.txId = null;
}
};

PostgreSQL.prototype.releaseConnection = function(connection, err) {
Expand Down