Type 'double precision' mapped to String#345
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@ataft, thanks for your contribution. Also, could you please add some test cases as well? Thanks. |
|
@dhmlau I'm not so great with git and don't know how to change the commit message. With regards to the tests, also not my strong suit, but the current "postgresql.discover.test.js" should cover this the 'double precision' type: |
|
@ataft, see if you can follow this instruction to change the commit message https://help.github.com/articles/changing-a-commit-message/. If not, don't worry, I can modify it for you. Thanks for pointing out the existing test. |
|
Let's get the commit message fixed so that CI can run successfully first. Thanks! |
|
Please modify, I cannot figure it out since I just made the change in the browser (not using command line). Can you also modify my other PR #347? Thanks! |
|
@slnode test please |
dhmlau
left a comment
There was a problem hiding this comment.
The change looks reasonable to me. But would like to get at least another review.
|
Thanks @ataft. Your PR has landed. Thanks for the contribution! |
On line 144, dataType "real" and "double precision" are changed to "float", but buildPropertyType has no case for "FLOAT":
https://github.com/strongloop/loopback-connector-postgresql/blob/master/lib/discovery.js#L144
This change simply adds a case statement for 'FLOAT'