fix(pool): synchronously release pool connection after query results Fix/conn release

[STRML]

Removes the process.nextTick() wrapping the release callback after calling pg.Pool#connect().

This was questioned in this comment and never removed. We found test flakiness that was alleviated after removing this unnecessary tick.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• Commit messages are following our guidelines

[dhmlau]

@STRML, thanks for the PR. Your changes look reasonable to me.
I'm not sure if we can add some tests for that. Would like to get other maintainers to review it as well. Thanks.

[dhmlau]

Just realized the errors after approving the PR. @STRML, could you please fix the commit linter error? Thanks.

**************************************************
**
**  Linting commit logs
**
**  2 problems found:
**    d32e3e6 - fix(pool): synchronously release pool connection af: First line should be 50 characters or less (saw 68)
**    d32e3e6 - fix(pool): synchronously release pool connection af: line 4 longer than 72 characters.
**
**************************************************

[elv1s]

looks good after fixing the commit message

[STRML]

Fixed commit message.

[bajtos]

**************************************************
**
**  Linting commit logs
**
**  1 problems found:
**    6ebfcb9 - fix(pool): synchronously release pool connection: line 4 longer than 72 characters.
**
**************************************************

To speed up the process, I am going to fix the commit message myself.

[bajtos]

14:07:46   1) autoupdate
14:07:46        foreign key constraint
14:07:46          should create, update, and delete foreign keys:
14:07:46      error: duplicate key value violates unique constraint "pg_namespace_nspname_index" (while running initial autoupdate)
14:07:46       at Connection.parseE (node_modules/pg/lib/connection.js:606:11)
14:07:46       at Connection.parseMessage (node_modules/pg/lib/connection.js:403:19)
14:07:46       at Socket.<anonymous> (node_modules/pg/lib/connection.js:123:22)
14:07:46       at addChunk (_stream_readable.js:263:12)
14:07:46       at readableAddChunk (_stream_readable.js:250:11)
14:07:46       at Socket.Readable.push (_stream_readable.js:208:10)
14:07:46       at TCP.onread (net.js:601:20)

The build failure looks unrelated to me, let's re-run the tests again.

IIRC, we are observing this error from time to time, it would be great if somebody could investigate the problem and contribute a fix. /cc @strongloop/loopback-connector-postgresql-maintainers

[bajtos]

@slnode test please

[bajtos]

Landed, thank you @STRML for the contribution ❤️

[bajtos]

Published as loopback-connector-postgresql@3.8.1 🚀