Skip to content

Conversation

@frbuceta
Copy link
Contributor

@frbuceta frbuceta commented Feb 1, 2021

See loopbackio/loopback-next#7054

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@frbuceta
Copy link
Contributor Author

frbuceta commented Feb 1, 2021

Thats weird! Actions are not executed. Could they be disabled for me? @strongloop/loopback-maintainers

@achrinza
Copy link
Member

achrinza commented Feb 1, 2021

IIRC, the incoming PR must be from a branch in the main repo (i.e. not a fork); Otherwise, GitHub will not execute the changes until it's merged.

@frbuceta
Copy link
Contributor Author

frbuceta commented Feb 1, 2021

IIRC, the incoming PR must be from a branch in the main repo (i.e. not a fork); Otherwise, GitHub will not execute the changes until it's merged.

I don't have permissions to create a branch in this repository, can you give me access?

@mrmodise
Copy link

mrmodise commented Feb 1, 2021

@frbuceta do a pull request to your own folked master it will run pipeline and reference here. @bajtos will need to update the repo settings for it to run Github actions

@frbuceta
Copy link
Contributor Author

frbuceta commented Feb 1, 2021

This is the proof that it works correctly https://github.com/frbuceta/loopback-connector-postgresql/pull/1#issue-565051760

@dhmlau
Copy link
Member

dhmlau commented Feb 1, 2021

@frbuceta, thanks for the PR.
I checked the settings. The Actions permission is set to "allow all actions". Not sure where else needs to be changed.
@bajtos, any idea?

@bajtos
Copy link
Member

bajtos commented Feb 2, 2021

I suspect it's the cause described by @achrinza in his comment #473 (comment) :

IIRC, the incoming PR must be from a branch in the main repo (i.e. not a fork); Otherwise, GitHub will not execute the changes until it's merged.

I think the next step is to merge this PR and then fix any issues in follow-up PRs.

@frbuceta
Copy link
Contributor Author

frbuceta commented Feb 2, 2021

I suspect it's the cause described by @achrinza in his comment #473 (comment) :

IIRC, the incoming PR must be from a branch in the main repo (i.e. not a fork); Otherwise, GitHub will not execute the changes until it's merged.

I think the next step is to merge this PR and then fix any issues in follow-up PRs.

As it is now, it should work. You can merge

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal looks great to me!

Let's use a different workflow name please per my comment below.

Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
@frbuceta frbuceta requested a review from bajtos February 2, 2021 11:10
@bajtos bajtos merged commit ebb2c72 into loopbackio:master Feb 2, 2021
@bajtos
Copy link
Member

bajtos commented Feb 2, 2021

Landed, thank you @frbuceta ❤️

@bajtos
Copy link
Member

bajtos commented Feb 2, 2021

@frbuceta frbuceta deleted the switch-to-github-actions branch February 2, 2021 12:21
@bajtos
Copy link
Member

bajtos commented Feb 2, 2021

Reverting this change in #474.

Let's try the new setup in your personal fork first, @frbuceta. Create a feature branch, open a PR against your own repo. Once you fix all issues, then the next step is open a PR from your feature branch to the upstream repo (https://github.com/strongloop/loopback-connector-postgresql).

@agnes512
Copy link
Contributor

agnes512 commented Feb 3, 2021

@frbuceta
Copy link
Contributor Author

frbuceta commented Feb 3, 2021

this might help https://github.com/marketplace/actions/setup-postgresql

This is a shortcut to what we are using right now in the code. This afternoon we have executed (@bajtos) the code in my fork but here it is not working correctly. @bajtos is investigating why this happens.

See https://github.com/frbuceta/loopback-connector-postgresql/pull/1

@bajtos
Copy link
Member

bajtos commented Feb 8, 2021

Sorry for the delay. There is a lot on my plate these days and what's worse, I fell sick. It makes me wonder, would you @agnes512 have bandwith to take over this work from me? My idea was to create a new feature branch in this repo, cherry-pick @frbuceta's commit, open a pull request and then tweak the settings or our tests until all GH actions are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants