-
Notifications
You must be signed in to change notification settings - Fork 183
Switch Travis to GitHub Actions #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thats weird! Actions are not executed. Could they be disabled for me? @strongloop/loopback-maintainers |
|
IIRC, the incoming PR must be from a branch in the main repo (i.e. not a fork); Otherwise, GitHub will not execute the changes until it's merged. |
I don't have permissions to create a branch in this repository, can you give me access? |
|
This is the proof that it works correctly https://github.com/frbuceta/loopback-connector-postgresql/pull/1#issue-565051760 |
|
I suspect it's the cause described by @achrinza in his comment #473 (comment) :
I think the next step is to merge this PR and then fix any issues in follow-up PRs. |
As it is now, it should work. You can merge |
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal looks great to me!
Let's use a different workflow name please per my comment below.
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
|
Landed, thank you @frbuceta ❤️ |
|
Hmm, the first build failed - see https://github.com/strongloop/loopback-connector-postgresql/actions/runs/530701696 |
|
Reverting this change in #474. Let's try the new setup in your personal fork first, @frbuceta. Create a feature branch, open a PR against your own repo. Once you fix all issues, then the next step is open a PR from your feature branch to the upstream repo (https://github.com/strongloop/loopback-connector-postgresql). |
|
this might help https://github.com/marketplace/actions/setup-postgresql |
This is a shortcut to what we are using right now in the code. This afternoon we have executed (@bajtos) the code in my fork but here it is not working correctly. @bajtos is investigating why this happens. See https://github.com/frbuceta/loopback-connector-postgresql/pull/1 |
|
Sorry for the delay. There is a lot on my plate these days and what's worse, I fell sick. It makes me wonder, would you @agnes512 have bandwith to take over this work from me? My idea was to create a new feature branch in this repo, cherry-pick @frbuceta's commit, open a pull request and then tweak the settings or our tests until all GH actions are passing. |
See loopbackio/loopback-next#7054
Checklist
npm testpasses on your machine