Conversation
ssh24
force-pushed
the
refactor-migration-ibmdb
branch
from
5b24906 to
7be53ba
Compare
jannyHou
reviewed
Mar 1, 2017
| if (err) { | ||
| return done(Error(err)); | ||
| } | ||
| // TODO: VALIDATE fields/indexes against model definition |
Contributor
There was a problem hiding this comment.
We can implement empty functions here if details are not provided.
So we can remove isActual here, use the one in base connector, and add two empty functions getAddModifyColumns and getColumnsToDrop here
ssh24
changed the title
Contributor
|
@slnode test please |
ssh24
force-pushed
the
refactor-migration-ibmdb
branch
from
7be53ba to
396b710
Compare
Contributor
|
@slnode test please |
Contributor
|
@ssh24 I think we need to create a new file |
qpresley
reviewed
Mar 2, 2017
Collaborator
qpresley
left a comment
qpresley
left a comment
There was a problem hiding this comment.
I really don't think these changes are valid. Not all databases that loopback-ibmdb is a dependency on support the same SQL statements for the functions being executed. For example, none of these will work in DB2z, DB2i or Informix. I think we need to re-think this move.
ssh24
force-pushed
the
refactor-migration-ibmdb
branch
from
8eafc71 to
ba02b96
Compare
Add alterTable as a base function Move showFields and showIndexes function Extract isActual Take out isActual as it inherits from base connector Add getAddModifyColumns and getDropColumns as empty fn Extract migration functions to a file
ssh24
force-pushed
the
refactor-migration-ibmdb
branch
from
ba02b96 to
072ad63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.