Skip to content

Set connection properties#44

Merged
qpresley merged 2 commits intomasterfrom
setConnectionProperties
Mar 10, 2017
Merged

Set connection properties#44
qpresley merged 2 commits intomasterfrom
setConnectionProperties

Conversation

@qpresley
Copy link
Copy Markdown
Collaborator

@qpresley qpresley commented Mar 10, 2017

Adding the setConnectionProperties prototype to allow the connection settings to differ for each IBM connector. For example, DB2 allows the use of "CurrentSchema" in the DSN but doesn't allow for "AUTHENTICATION=SERVER" while Informix does not allow "CurrentSchema" but requires "AUTHENTICATION=SERVER"

loay
loay approved these changes Mar 10, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@loay loay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qpresley qpresley merged commit 64cba58 into master Mar 10, 2017
@qpresley qpresley deleted the setConnectionProperties branch March 10, 2017 16:00
kjdelisle pushed a commit that referenced this pull request Mar 10, 2017
2.1.0
1c3446d 
 * Set connection properties (#44) (Quentin Presley)
 * Fix replaceById bug (Loay)
 * Upgrade to loopback-connector@4.0.0 (jannyHou)
 * Use trim on table name (ssh24)
 * Refactor migration methods (biniam)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@loay loay loay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qpresley @loay