Conversation
qpresley
reviewed
Jul 12, 2017
Contributor
Author
|
@qpresley Removed L80 and added the column escape function on the property name. |
ssh24
force-pushed
the
escape-columnName
branch
2 times, most recently
from
4e4d242 to
a8ec2c7
Compare
b-admike
approved these changes
Jul 12, 2017
qpresley
approved these changes
Jul 12, 2017
Contributor
Author
|
@slnode test please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add escape function on the column names in add, change and drop operations to allow the underlying database deal with the name escaping.
connect to #53