Conversation
loay
reviewed
Jul 24, 2017
| debug('IBMDB.prototype.executeSQL (exit)' + | ||
| ' stmt=%j params=%j err=%j data=%j more=%j', | ||
| stmt, params, err, data, more); | ||
| stmt, params, err, data, more); |
Contributor
There was a problem hiding this comment.
It should have been on the same level as the previous line ..
I think line 257 shoudl be pushed back with less indent spaces .. I am not sure how it is not caught by linting !
Contributor
Author
There was a problem hiding this comment.
The ./node_modules/.bin/eslint --fix . fixed it this way.
loay
suggested changes
Jul 24, 2017
Contributor
Author
|
@loay That is how the linting rules are on eslint v4. IMO, the line is correctly indented. debug('IBMDB.prototype.executeSQL (exit)' +
' stmt=%j params=%j err=%j data=%j more=%j',
stmt, params, err, data, more);PS. Check the CI builds to see that the linting is actually working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update eslint to v4 and use the
loopbackextension.